deps: common v0.5.15; registry reconnect cannot race Stop - #471
Merged
Merged
Conversation
common v0.5.15 (pilot-protocol/common#51, #52): idempotent registry Client.Close (fixes the 'close of closed channel' panic in every nightly since 07-26), pool reconnects keep their cause, log at Debug with a periodic summary, back off with jitter and retry on a healthy conn (113,804 'reconnected' INFO lines were 57% of one daemon.log), and the proxy credential refresh used by the upcoming Muse support. forceReconnectRegistry now declines once Stop has begun and closes the conn it installed if Stop won the race, so a heartbeat or rx-watchdog reconnect during shutdown no longer leaks a registry pool. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // Stop may have closed the registry between the check above and the | ||
| // swap; if so it closed the old conn, so close the one we installed. | ||
| if d.stopping() { | ||
| newConn.Close() |
TeoSlayer
enabled auto-merge (squash)
September 24, 2026 02:08
TeoSlayer
pushed a commit
that referenced
this pull request
Sep 24, 2026
… into feat/native-https-proxy Conflicts: - cmd/daemon/main.go: one fileConfig for both flagSources (recorded before ApplyToFlags) and #464's flagExplicit; logging.Setup stays early (the transport/proxy resolution logs), so #464's logcap.Watch moves up with it; the daemon start failure keeps #464's fatalAfterPluginStart. - cmd/daemon/shutdown.go: fatalAfterPluginStart logs at ERROR (slog), like the branch's fatalf, so pilotctl daemon start can report it. - CHANGELOG.md: both Fixed lists kept. - go.mod: tidy (golang.org/x/net indirect again, as on main, now that the branch-local refresh policy is gone). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Client.Close— fixes theclose of closed channelpanic seen in every nightly since 07-26 (sweep item 8); pool reconnects keep their cause, log at Debug with a periodic INFO summary, jittered backoff, retry on a healthy pooled conn (sweep item 5: 113,804 "reconnected" INFO lines = 57% of one daemon.log); netproxy credential refresh (inert until wired by the Muse work).forceReconnectRegistryreturnserrDaemonStoppingonce Stop began, and closes the conn it installed if Stop won the race — no leaked registry pool from a heartbeat/rx-watchdog reconnect during shutdown. Regression testTestForceReconnectRegistryAfterStopDoesNotReplaceConn.GOWORK=off go test ./pkg/daemon/... ./cmd/...green; new/related tests green under-race -count=3.🤖 Generated with Claude Code