Log unsupported resource limits once on macOS - #41
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
One scan of the process table could miss an orphan (on macOS the argv read fails transiently while a process is mid-fork), leaving it running until the next spawn. Rescan up to 3 passes; TestReapStaleKillsEveryInstance went from ~50% failure to 6/6 locally. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
TeoSlayer
marked this pull request as ready for review
September 24, 2026 18:14
TeoSlayer
enabled auto-merge (squash)
September 24, 2026 18:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On non-Linux hosts every child spawn logs the same unsupported-resource-limit warning. Emit one process-wide warning with sync.Once while keeping the limitation visible. Concurrent spawns now produce exactly one line.
Addresses pilot-protocol/pilotprotocol#481 (item 4). This dependency change must be released and consumed by pilotprotocol before that item is resolved in shipped binaries.
Validation: the concurrent-warning regression passes with the race detector. The broader plugin suite has an unrelated TestReapStaleKillsEveryInstance failure, reproduced separately on the unchanged app-store checkout; it is not caused by this change.