All config Elements should be initializeable with an empty model object. #124

Activity

1. evaneus

   assigned

   sergiulucaci

   on Mar 4, 2019
2. edeustace commented on Mar 5, 2019

   

   edeustace

   on Mar 5, 2019

   Contributor

   More actions

   I think there are 3 parts to this.

   1. the ui will render without blowing up, if the model is incomplete/empty.
   2. the controller should be able to render a ui model without blowing up, if the model is incomplete/empty
   3. if the model is empty, render some form of default model.

   I think part 3 requires a bit more thought as to what the flow should be.

   Basically the question is where should the logic to build a default model live, ahd what would be flow around using it?

   For me it's either put it the UI element or put it in the controller

   If you put it in the UI element, the rendering context will need to handle 'model-updated' and persist the change.

   If you put it in the controller, the rendering context will create the model using a controller method say createConfigModel(), save it, then pass that into the ui.

   I'd vote for exposing this method on the controller. The controller is available in the rendering context, so is simple to call. Also I think the controller should be in charge of managing the model.

   const newElement = ( elementType ) => {
     const model = pie[elementType].controller.createConfigModel( {id: '1', prompt: 'custom prompt'});
     save(model)
       .then( ( ) => {
          el.model = model;
       })
   }