Add super-linter - #1
Merged
Merged
Conversation
Same configuration as the other repos: super-linter v8 pinned to a commit SHA, least-privilege permissions, and a checkout that does not persist the job token. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012ozRgn6mdQHtjoWbGfDWw2
persist-credentials: false on checkout steps that only read the tree, which is zizmor's artipacked finding. Workflows that push keep the credential. prettier --write over the file types super-linter's *_PRETTIER linters cover. Formatting only, no content changes. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012ozRgn6mdQHtjoWbGfDWw2
Its terminology rules fight the prose in these repos more than they help — the false positives outnumber the real findings. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012ozRgn6mdQHtjoWbGfDWw2
JSCPD flags intentional repetition — generated files and repeated
markup — far more often than real duplication, so it is off.
codespell stays on for real typos, but skips binaries and lockfiles
(it was reading PDFs as text) and ignores four words it gets wrong:
coo, pres, unparseable, and lifes ('still lifes' is the Game of Life
term of art).
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012ozRgn6mdQHtjoWbGfDWw2
super-linter runs BIOME_FORMAT and the *_PRETTIER linters over the same files, but biome indents with tabs and prettier with spaces, so no formatting can satisfy both. prettier wins because it covers markdown, html, css, yaml and json as well. BIOME_LINT is unaffected — it is a linter, not a formatter. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012ozRgn6mdQHtjoWbGfDWw2
biome and stylelint both lint CSS with different opinions. biome is the more widely used and also covers js/ts, so stylelint is the one dropped. The formatters are re-run pinned to the versions super-linter actually ships (ruff 0.15.17, black 26.5.1, isort 8.0.1, prettier 3.8.4). Running newer local versions produced formatting CI then rejected. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012ozRgn6mdQHtjoWbGfDWw2
black and ruff format both run in CI and disagree on assert-message wrapping, which no config setting reconciles. ruff is far more widely used, its formatter is >99.9% black-compatible, and it also covers what isort and flake8 do, so black is the one dropped. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012ozRgn6mdQHtjoWbGfDWw2
Turns off the rules that fire on correct patterns in this codebase rather than on defects, each annotated with why. Rules that find real problems - MD025, MD040, the biome correctness set, mypy - stay on. pylint's max-line-length is aligned to the ruff config so the two tools cannot drift apart. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012ozRgn6mdQHtjoWbGfDWw2
htmlhint keeps its standard checks but drops doctype-first (Jinja partials are fragments) and id-class-value (camelCase ids are standard in JS-driven pages, and these are queried by name from script). super-linter warns that biome and eslint both lint JSON and may conflict; biome is kept, matching the call already made for CSS. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012ozRgn6mdQHtjoWbGfDWw2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds super-linter, matching the configuration used across the other repos: v8 pinned to a commit SHA, least-privilege
permissions, and a checkout that does not persist the job token.This is the first time this repo has been linted, so the run may surface pre-existing findings. Not merged pending review of what it reports.
🤖 Generated with Claude Code