Form::getValues(bool) broken

Hello,
we're using older version of Nette, where method Container::getValues accepted only bool. The (pseudocode) signature of the method was:

/**
 * @return $asArray is true ? array<string, mixed> : ArrayHash
 */
Container::getValues(bool $asArray = false)

With the latest version, PHPStan thinks, that all the calls of Form::getValues(true) returns ArrayHash, but in reality, the array is returned:

I think it is a bug introduced in this PR #175.

Either support for old version of Nette should be capped in composer.json or the code should align by the version of nette/forms installed.

Thanks for an awesome extension though! I'm always keen on working with PHPstan.

Plus I've noticed, that README.md still contains

Nette\Forms\Container::getValues return type based on $asArray parameter.

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Navigation Menu