-
Notifications
You must be signed in to change notification settings - Fork 14
Fix notify #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Fix notify #37
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 changes: 51 additions & 0 deletions
51
tests/Unit/WorkDoneProgress/MessageProgressNotifierTest.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| <?php | ||
|
|
||
| namespace Phpactor\LanguageServer\Tests\Unit\WorkDoneProgress; | ||
|
|
||
| use PHPUnit\Framework\TestCase; | ||
| use Phpactor\LanguageServer\Core\Server\ClientApi; | ||
| use Phpactor\LanguageServer\Core\Server\ResponseWatcher\TestResponseWatcher; | ||
| use Phpactor\LanguageServer\Core\Server\RpcClient\TestRpcClient; | ||
| use Phpactor\LanguageServer\Core\Server\Transmitter\TestMessageTransmitter; | ||
| use Phpactor\LanguageServer\WorkDoneProgress\MessageProgressNotifier; | ||
| use Phpactor\LanguageServer\WorkDoneProgress\ProgressNotifier; | ||
| use Phpactor\LanguageServer\WorkDoneProgress\WorkDoneToken; | ||
|
|
||
| class MessageProgressNotifierTest extends TestCase | ||
| { | ||
| /** | ||
| * @var TestMessageTransmitter | ||
| */ | ||
| private $transmitter; | ||
| /** | ||
| * @var TestRpcClient | ||
| */ | ||
| private $api; | ||
|
|
||
| protected function setUp(): void | ||
| { | ||
| $this->transmitter = new TestMessageTransmitter(); | ||
| $this->api = new TestRpcClient($this->transmitter, new TestResponseWatcher()); | ||
| } | ||
|
|
||
| public function testBegin(): void | ||
| { | ||
| $token = WorkDoneToken::generate(); | ||
| $this->createNotifier()->begin($token, 'Hello'); | ||
| self::assertEquals(1, $this->transmitter->count()); | ||
| self::assertEquals('Hello', $this->transmitter->shiftNotification()->params['message']); | ||
| } | ||
|
|
||
| public function testBeginMessageAndPercentage(): void | ||
| { | ||
| $token = WorkDoneToken::generate(); | ||
| $this->createNotifier()->begin($token, 'Indexer', 'this may take some time', 50); | ||
| self::assertEquals(1, $this->transmitter->count()); | ||
| self::assertEquals('Indexer: this may take some time, 50% done', $this->transmitter->shiftNotification()->params['message']); | ||
| } | ||
|
|
||
| private function createNotifier(): ProgressNotifier | ||
| { | ||
| return new MessageProgressNotifier(new ClientApi($this->api)); | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we should include the title.
I think it's ment to have a title in a notification window, when showing a message it might get redundant.
With the example of the indexing we will get something like
Indexing: Indexing X filesBut I admit I went to quickly on the implementation...
For the
reportI should have handled the cases when the message and or the percentage are not provided.We could have result like
- 10%, which is not really good.And we might want to not send any message if we don't provide any of this two parameters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will try to improve it on this branch and push a proposition, you'll decide then if you keep it or not :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Silly me, I forgot I can't work on this branch directly 😄
camilledejoye@40f222c