Check for Windows utf-8 support in run-tests.php - #4404
Closed
TysonAndre wants to merge 1 commit into
Closed
Conversation
Windows terminals can have different codepages. In some locales (especially in older OS versions), the default codepage isn't necessarily utf-8. Non-utf8 codepages wouldn't render this utf-8 character properly.
Member
|
I'd suggest to just drop the lightning instead... |
Contributor
Author
|
I'm ambivalent about keeping or removing the lightning. This just seemed like a quick fix that could get approved without objection or reverts - #3981 (comment) also brought up the Ideally php would have a native cross-platform equivalent of |
Member
|
Lightning removed in 562591f. |
Member
|
See also 55d34f7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows terminals can have different codepages.
In some locales (especially in older OS versions),
the default codepage isn't necessarily utf-8.
Non-utf8 codepages wouldn't render this utf-8 character properly.
This is based on a similar utf-8 check in a different application : phan/phan@874e908#diff-c47b128e8e4f783d984687a8796dc74dR1464