Skip to content

[EXPERIMENTAL] Skip slow tests on Appveyor #3789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cmb69 wants to merge 2 commits into from
Closed

[EXPERIMENTAL] Skip slow tests on Appveyor #3789

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d085cd8
Skip slow tests on Appveyor
cmb69 Feb 2, 2019
760986d
Show all test durations
cmb69 Feb 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion appveyor/test_task.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,10 @@ mkdir c:\tests_tmp

set TEST_PHP_JUNIT=c:\junit.out.xml

set SKIP_SLOW_TESTS=1

cd "%APPVEYOR_BUILD_FOLDER%"
nmake test TESTS="%OPCACHE_OPTS% -q --offline --show-diff --show-slow 1000 --set-timeout 120 -g FAIL,XFAIL,BORK,WARN,LEAK,SKIP --temp-source c:\tests_tmp --temp-target c:\tests_tmp"

@nikic nikic Feb 2, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the --show-slow dropped here?

It might be interesting to do a run with --show-slow 0 to get a full list of test timings, including the "fast" ones (which are probably comparatively slow on AppVeyor).

@cmb69 cmb69 Feb 2, 2019

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I've mistankenly assumed that --show-slow is only about slow tests.

Anyhow, it seems skipping the slow tests saves quite some time.

nmake test TESTS="%OPCACHE_OPTS% -q --offline --show-diff --show-slow 0 --set-timeout 120 -g FAIL,XFAIL,BORK,WARN,LEAK,SKIP --temp-source c:\tests_tmp --temp-target c:\tests_tmp"

set EXIT_CODE=%errorlevel%

Expand Down