openssl: Check return value of SSL_CTX_set_alpn_protos()

[ndossche]

Discovered by ESSS.

[bukka]

Hmm looking at https://github.com/openssl/openssl/blob/77f492f29f882e07d57e16920138d991dc9af018/ssl/ssl_lib.c#L3870-L3882 it seems like it might be possible to make it fail (e.g. single letter value so test might be possible if I read it correctly.

[ndossche]

Hmm looking at https://github.com/openssl/openssl/blob/77f492f29f882e07d57e16920138d991dc9af018/ssl/ssl_lib.c#L3870-L3882 it seems like it might be possible to make it fail (e.g. single letter value so test might be possible if I read it correctly.

Yeah, I added a test and adjusted the error type

[bukka]

technically it could fail on memdup but such message wouldn't be probably visible anyway so it's better to keep like this.

[bukka]

Seems like a bug so should go to 8.4+

[ndossche]

technically it could fail on memdup but such message wouldn't be probably visible anyway so it's better to keep like this.

Yes, I agree, we can't distinguish what exactly failed at the call site so this is the pragmatic approach.

[ndossche]

Seems like a bug so should go to 8.4+

This particular patch uses the new API php_stream_warn. So I'll merge this to master and then prepare a backport PR for 8.4.