Fix run-tests.php --file-cache-prime with multiple workers - #22886
Merged
Conversation
We want to remove the directory only before running tests, rather than for every test. That causes races, but also defeats the purpose of priming the cache.
These need to live in ext/opcache/tests to be skipped by run-tests.php for the --file-cache-use tests, which won't compile the files and thus won't dump the output.
Preloading requires shm.
adrian-enspired
pushed a commit
to adrian-enspired/php-src
that referenced
this pull request
Aug 4, 2026
* Fix run-tests.php --file-cache-prime with multiple workers We want to remove the directory only before running tests, rather than for every test. That causes races, but also defeats the purpose of priming the cache. * Move opcache.opt_debug_level tests These need to live in ext/opcache/tests to be skipped by run-tests.php for the --file-cache-use tests, which won't compile the files and thus won't dump the output. * Mark preloading test as opcache.file_cache_only=0 Preloading requires shm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to remove the directory only before running tests, rather than for every test. That causes races, but also defeats the purpose of priming the cache.