Properly propagate failure of X509_STORE_CTX_new() - #22625
Merged
Conversation
Propagating is consistent with other "new" failures, and avoids bailing out, which is inherently problematic anyway as it can cause persistent leaks on its own.
ndossche
changed the title
Girgias
reviewed
Aug 3, 2026
| if (csc == NULL) { | ||
| php_openssl_store_errors(); | ||
| php_error_docref(NULL, E_ERROR, "Memory allocation failure"); | ||
| php_error_docref(NULL, E_WARNING, "Memory allocation failure"); |
Member
There was a problem hiding this comment.
I guess it's basically impossible to create a test for this, but as I'm unfamilar with openssl, I'm assuming that the call to X509_STORE_CTX_new doesn't store any relevant error, so that's why we need the extra warning?
Member
Author
There was a problem hiding this comment.
It will store an error that can be looked at via the error queue.
However, ext/openssl is inconsistent: in some cases only the error in the error queue is stored and in other cases an additional warning is emitted
Member
There was a problem hiding this comment.
Okay, well pre-exiting behaviour so lets just leave it like that then.
Girgias
approved these changes
Aug 3, 2026
Girgias
left a comment
Girgias
left a comment
Member
There was a problem hiding this comment.
Always in favour of getting rid of a bailout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagating is consistent with other "new" failures, and avoids bailing out, which is inherently problematic anyway as it can cause persistent leaks on its own.
Originally reported as a part of #21643, but the other issues there are all semantic whereas this is specific to ASAN.