Fix GH-21746 - #21891
Closed
arnaud-lb wants to merge 1 commit into
Closed
Conversation
Contributor
|
I confirmed that this patch resolves both the |
Member
Author
|
@theodorejb I can not guarantee it, but there is a good chance it will |
arnaud-lb
marked this pull request as ready for review
April 28, 2026 07:28
Member
|
8.5.6 RC is already tagged (has been for almost two weeks), so this won't land unless cherry-picked, but that's unlikely given it's not a new regression. |
Member
Author
|
Oh, forgot about RCs |
adrian-enspired
pushed a commit
to adrian-enspired/php-src
that referenced
this pull request
Aug 4, 2026
Restores c6ea352, which was likely lost in the rebase of 84fd7fa Fixes phpGH-21746 Closes phpGH-21891
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes GH-21746
This is the same fix as 79aaeea, which was likely lost in the rebase of 76d7c61.
In the reproducer, variable
$iofLR::p()was marked asZREG_STORE, and the store happened after leavingLR::p's frame, so it was overriding some variable in the parent frame.