ext/intl: get_icu_value_internal() to reduce manual memory manageme… - #19433
Merged
Conversation
devnexen
marked this pull request as ready for review
August 9, 2025 21:03
devnexen
changed the title
LamentXU123
approved these changes
Aug 3, 2026
LamentXU123
left a comment
LamentXU123
left a comment
Member
There was a problem hiding this comment.
Make sense. But I think this still needs to go through CI after rebasing to master
Be careful something has been changed (const qualifiers and the UNEXPECTED macro additions)
Member
|
Also you may need to #include <memory> in some cases. |
devnexen
force-pushed
the
intl_locale_methods
branch
from
August 3, 2026 18:12
d55c856 to
d1ade85
Compare
devnexen
force-pushed
the
intl_locale_methods
branch
from
August 3, 2026 18:15
d1ade85 to
464dd1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nt a bit.