Skip to content

Document new key builtin_default_value of the array returned by ini_get_all() in PHP >= 8.6.0 - #5581

Open
sebastianbergmann wants to merge 2 commits into
php:masterfrom
sebastianbergmann:master
Open

Document new key builtin_default_value of the array returned by ini_get_all() in PHP >= 8.6.0#5581
sebastianbergmann wants to merge 2 commits into
php:masterfrom
sebastianbergmann:master

Conversation

@sebastianbergmann

Copy link
Copy Markdown
Contributor

This updates the documentation for ini_get_all() after php/php-src#22134.

@sebastianbergmann sebastianbergmann changed the title Document new key "builtin_default_value" of the array returned by ini_get_all() in PHP >= 8.6.0 Document new key builtin_default_value of the array returned by ini_get_all() in PHP >= 8.6.0 May 25, 2026

@jordikroon jordikroon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a few style guide nits. Also meant to reduce the chances of a merge conflict later om.

Comment thread reference/info/functions/ini-get-all.xml Outdated
Comment thread reference/info/functions/ini-get-all.xml Outdated
Comment thread reference/info/functions/ini-get-all.xml Outdated
@jordikroon

Copy link
Copy Markdown
Member

This should probably wait until PHP 8.6 actually drops.

@jordikroon jordikroon added this to the PHP 8.6 milestone May 25, 2026

<refsect1 role="returnvalues">
&reftitle.returnvalues;
<para>

This comment was marked as low quality.

Returns an associative array with directive name as the array key.
Returns &false; and raises an <constant>E_WARNING</constant> level error
if the <parameter>extension</parameter> doesn't exist.
</para>

This comment was marked as off-topic.

Comment on lines 64 to 77
@@ -74,6 +77,31 @@
</note>

This comment was marked as off-topic.

@jordikroon

Copy link
Copy Markdown
Member

@lacatoire as long as those inner para's do not change. There is no need to suggest to migrate to simpara. It will only put the bar up unnecessarily for the contributors. Though it's up to Sebastian if he wishes to include them. It's just extra maintenance work.

@sebastianbergmann

Copy link
Copy Markdown
Contributor Author

This should probably wait until PHP 8.6 actually drops.

This updates the documentation of ini_get_all() for PHP 8.6, yes. I do not know the policy for the documentation, sorry, so I do not know whether this can be merged now or whether it needs to wait until PHP 8.6 has been released.

@jordikroon

Copy link
Copy Markdown
Member

@sebastianbergmann there isn't really a policy, but best to wait for alpha 1 before merging.
That said any MR targeting 8.6 is very welcome and will save us time preparing. So we are very happy with it (If only more would do this ^^).

Co-authored-by: Jordi Kroon <jordi@jordikroon.nl>
@jordikroon

Copy link
Copy Markdown
Member

In preparation for 8.6, this has been rebased and style changes have been fixed.
No further action required, and ready to be merged once RC1 or Hard freeze is place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants