Repository navigation
Stop leaking the environment to student code - #316
Merged
Merged
Conversation
AydinHassan
changed the title
The env was stripped using $_ENV, which is empty when variables_order lacks E, so secrets leaked to the process. When it was populated, PATH was removed too, so composer could not find php. Input env now also overrides the defaults. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
AydinHassan
force-pushed
the
stack/1e2-env-leak
branch
from
October 22, 2026 19:00
df36f18 to
9db4444
Compare
An error occurred while trying to automatically change base from
stack/1e-phpstan2
to
master
October 22, 2026 19:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HostProcessFactory meant to strip the inherited environment before running student code, but:
$_ENV, which is empty whenvariables_orderlacksE(the usual production setting), so nothing was stripped and secrets leaked to the process$_SERVER($env + array_map(...)) discarded its result$_ENVwas populated,PATHwas stripped too, so composer could not find phpNow the names come from
getenv(), and onlyPATH,HOMEandCOMPOSER_HOMEare kept. Input env is merged over the defaults so it can override them.🤖 Generated with Claude Code