Repository navigation
Conversation
Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PyTorch builds such as NVIDIA 26.08 expose part of the opaque-object API but lack
is_opaque_constant_type, which Transformer Engine requires to register its quantizers. The compile test module currently treats those builds as supported and fails during collection when defining its QDQ operators.Check for the required predicate before defining opaque test operators and skip the module's test cases when it is absent. Supported builds retain the same collected tests. This changes only tests.
Type of change
Changes
is_opaque_constant_typein the opaque API availability check.test_torch_compile.pyskipped when the required API is unavailable, preserving a successful pytest exit status.Validation
Validated on RTX 5880 Ada, PyTorch
2.15.0a0+875d815502.nvinternal.main, pytest 8.2.1, using the upstream Python sources and existing native libraries:is_opaque_constant_typein an isolated process before importing TE: baseline reproduces the collection error; patched module reports 392 skipped and exit code 0.The missing API was simulated on PyTorch 2.15; the 26.08 image and full numerical suite were not rerun.
Checklist: