Repository navigation
Conversation
Author
|
I found a dispatch regression while auditing this change: local filenames such as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return an empty iterator for valid empty FeatureCollections and readable zero-feature datasets. A spatial filter can produce these selections, and RFC 7946 section 3.3 permits an empty
featuresarray. Currently, GeoDataFrames and collections are rejected by a truthiness check, while empty files fail the vector-source probe.For inputs that are not existing local paths, parse inline GeoJSON before probing file sources. This keeps the documented file-only
enginesetting from sending JSON text tofiona.open(), and preserves original feature IDs instead of replacing them through GDAL.The regressions and recorded polygon/point selections cover both engines, GeoJSON/GeoPackage/Shapefile and in-memory inputs. All 131 tests pass with older dependencies; current Affine/Shapely require the same two existing deprecation-warning filters as the baseline. Ruff checks/formatting, an installed-wheel replay and composition with the NaN-nodata correction pass. Working geometry, properties and query/statistics results remain unchanged.
Existing local paths retain priority even when the filename is valid JSON, such as
123or{}; regressions cover string and Path inputs.