Skip to content

fix(docs): don't show inherited typescript props - #1866

Merged
dlabaj merged 1 commit into
patternfly:masterfrom
redallen:feat/ts-docgen
Apr 26, 2019
Merged

fix(docs): don't show inherited typescript props#1866
dlabaj merged 1 commit into
patternfly:masterfrom
redallen:feat/ts-docgen

Conversation

@redallen

@redallen redallen commented Apr 26, 2019

Copy link
Copy Markdown
Contributor

What: Closes #1688

Additional issues:

@patternfly-build

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://1866-pr-patternfly-react-patternfly.surge.sh

@tlabaj tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io

codecov-io commented Apr 26, 2019

Copy link
Copy Markdown

Codecov Report

Merging #1866 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1866   +/-   ##
=======================================
  Coverage   82.59%   82.59%           
=======================================
  Files         621      621           
  Lines        6844     6844           
  Branches       93       93           
=======================================
  Hits         5653     5653           
  Misses       1151     1151           
  Partials       40       40
Flag Coverage Δ
#patternfly3 84.87% <ø> (ø) ⬆️
#patternfly4 79.29% <ø> (ø) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d588f0...abe4d9a. Read the comment docs.

@dlabaj
dlabaj merged commit a51e731 into patternfly:master Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

React-docs Typescript NOT Excluding Inherited Properties

6 participants