test(web): isolate BoardCard so Fork CI can go green - #476
Merged
Merged
Conversation
BoardCard now reads environmentServerConfigsAtom via useOpenPrLink. Under isolate:false a sibling (UsagePage.refresh) binds a partial ../../state/server mock first, and Fork CI fails all 11 BoardCard tests. That red push job blocked the poller from deploying dfx 1.0.16.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork CI on
b4ad10f8(dfx 1.0.16) failed twice on all 11BoardCardtests:No \"environmentServerConfigsAtom\" export is defined on the \"../../state/server\" mockBoardCard now opens PRs through
useOpenPrLink→ that atom. Underisolate: false,UsagePage.refresh.test.tsxbinds a stubstate/servermock first and poisons BoardCard. That red push job blocks the poller from deploying the Discord gateway fix.Isolate BoardCard and the stub mock so they cannot share a module registry.