Repository navigation
Fix credential setup timing and safe failure diagnostics - #30
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Credential setup can inspect the page before the intended input has painted, then fail before sending an authentication request. Wait within the existing timeout for one enabled, visible matching text field; reject ambiguous matches. Preserve fixed, value-free failure categories so secret-entry errors can be diagnosed without exposing credentials or provider error messages.
Validation: release ps-qa build and formatting passed. Actual rendered Pays production-profile username/password login and PlatformAdmin dashboard passed 9/9 against real services. No money or wallet writes.