Repository navigation
Let QA pointer drags target a painted destination - #27
Merged
Merged
Conversation
added 5 commits
September 26, 2026 10:28
Real Cmd arrives from winit as SUPER|META, and blitz-dom's text editing tests SUPER as the macOS action modifier. An injected Cmd+V carried META alone, so a text field typed a literal "v" instead of pasting.
`navigate` runs before `open` and sends the protocol's Navigate. A click in a client-routed app never loads a document, so a direct load (reloading /account while signed in) could not be checked at all. The check waits for its arrival target within open_timeout_ms, and a host that refuses Navigate fails the check with its error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Allow
pointer_dragchecks to name a painted destination withto, so ps-qa computes the drag displacement from the live renderer. This supports data-derived QA targets without hardcoding per-puzzle coordinates in check manifests. Existingdx/dychecks remain supported.Verification
cargo +stable fmt --all -- --checkcargo +stable clippy -p ps-qa --all-targets -- -D warningscargo +stable test -p ps-qa(164 unit tests passed; 2 CLI tests passed, 1 existing host-dependent test ignored)