fix(engine): invalidate getter inline caches after mutation - #25
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A getter can change its receiver's shape while the VM is resolving the property. The inline cache previously stored the resolved slot against the post-getter shape, so later reads could dispatch the getter again after it had installed an own value. In Chuzz, a memoizing DOM event getter then attempted to redefine a non-configurable property on every event.
This gives unique-shape insertions a fresh identity and records property/global getter cache entries against the shape that was actually searched. The focused regressions cover unique prototype getters, ordinary mutation, an event-style callback, and global getter mutation. The workspace version moves to 1.0.6 so the fix can publish as one compatible dependency batch.
Validation:
cargo fmt --all -- --checkcargo clippy -p ps-boa-engine --lib --no-deps -- -D warnings -A clippy::manual_assert_eqPlain
-D warningsis currently blocked by existingmanual_assert_eqfindings in unchangedcore/gc/src/cell.rsandcore/engine/src/value/equality.rs. The fork's automatic gate already documents and handles that upstream-only lint.