Repository navigation
Stop smr-ps-reclaim from dragging std in - #9
Merged
Merged
Conversation
The feature carried "std" with a comment saying ps-reclaim was std-only. That was true when it was written and stopped being true when ps-reclaim 0.1.4 published a no_std mode an hour ago, so a no_std Arctic could not use the reclamation backend it was written for. That combination is the point of the whole port and it has never once built. smr-ps-reclaim now asks for the platform pieces without std, and Arctic's own std feature forwards ps-reclaim/std, which wins inside that crate when both are on. So the two directions resolve the way they should: arctic default (std) ps-reclaim: std + libc + spin thread_local! arctic --no-default-features ps-reclaim: libc + spin pthread keys Verified against the published 0.1.4 with no path patches: 81 tests pass on default and on no_std + smr-ps-reclaim, 79 on no_std + smr-seize, clippy clean. The requirement moves to >=0.1.4 because default-features = false needs the libc and spin features, which 0.1.3 does not have. Version 0.1.11: merging publishes it.
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
smr-ps-reclaimcarried"std", with a comment saying ps-reclaim was std-only. That was true when written and stopped being true when ps-reclaim 0.1.4 published, so ano_stdArctic could not use the reclamation backend it was written for. That combination is the point of the whole port and has never once built.std)std+libc+spinthread_local!--no-default-features --features smr-ps-reclaimlibc+spinstdwins inside ps-reclaim when both are on, so the default build is unchanged.Verified against the published 0.1.4, no path patches
>=0.1.4becausedefault-features = falseneeds thelibcandspinfeatures, which 0.1.3 lacks.Version 0.1.11 — merging publishes it. Single commit, linear.