feat(wall): add endHeightOffset for sloped top edge - #640
Open
vducasse wants to merge 1 commit into
Open
Conversation
vducasse
force-pushed
the
feat/wall-end-height
branch
from
August 17, 2026 10:33
cf8f12c to
7200ea6
Compare
vducasse
force-pushed
the
feat/wall-end-height
branch
from
August 17, 2026 11:07
7200ea6 to
8910206
Compare
vducasse
force-pushed
the
feat/wall-end-height
branch
from
August 17, 2026 11:29
8910206 to
6a53abd
Compare
vducasse
force-pushed
the
feat/wall-end-height
branch
from
August 17, 2026 11:43
6a53abd to
f250e10
Compare
vducasse
force-pushed
the
feat/wall-end-height
branch
from
August 17, 2026 12:15
f250e10 to
d2b2045
Compare
vducasse
force-pushed
the
feat/wall-end-height
branch
from
August 17, 2026 12:48
d2b2045 to
a51d552
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a51d552. Configure here.
vducasse
force-pushed
the
feat/wall-end-height
branch
from
August 17, 2026 15:25
a51d552 to
621b349
Compare
- **Schema & Core Systems**:
- Add endHeightOffset property to WallNode schema with default 0.
- Update resolveWallTop and resolveWallOpeningCeiling to support
parametric height sampling along sloped top edges.
- Update getWallFaceBandConfig and getWallFaceBandForHeight to
scale with maximum sloped wall height.
- Update spatial grid synchronization, space detection, and level
height calculations for sloped walls.
- **3D Geometry & Viewer Systems**:
- Add applyWallEndHeightSlope in wall-system to interpolate vertices
at top extrusion plane while preserving foundation fill-downs.
- Update getWallBandSplitPlanes to split horizontal face bands across
the full sloped wall envelope.
- Add applyTrimSlope in treatments to slope crown molding trims.
- **Openings & Floorplan Tools**:
- Update door and window ceiling clearance math, floorplan move
handlers, and 3D move tools to respect sloped wall height.
- Fix resolveWallRole in paint to resolve face bands by elevation Y,
ensuring 1:1 parity with 3D mesh horizontal band splits.
- Update elevation guides, side move handles, snap beacons, and
wall measurement labels for sloped walls.
vducasse
force-pushed
the
feat/wall-end-height
branch
from
August 17, 2026 15:29
621b349 to
8cedc3a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What does this PR do?
Adds an
endHeightOffsetproperty to theWallNodeschema to allow wall extremities to have different heights (e.g., for creating a knee wall following a single-pitch roof slope). This adds an "End height offset" slider to the wall properties panel and updates the geometry generation to apply the slope along the top edge of the wall.How to test
End height offsetslider.Screenshots / screen recording
Checklist
bun devbun checkto verify)mainbranchNote
Medium Risk
Wide touch on wall height resolution, opening placement, and room/level bounds; behavior is consistent via shared
t-aware resolvers but regressions on flat walls or opening tools are possible.Overview
Adds
endHeightOffseton walls so the top edge can slope from start to end (knee walls / single-pitch roofs), with an End height offset control in the wall panel.Core & rendering:
resolveWallTop/ effective height now take an optional paramtalong the wall chord; the extruder tilts top vertices viaapplyWallEndHeightSlope. Room auto-ceiling and level max height consider both ends of sloped boundaries.Spatial & sync: Wall-on-wall placement uses the minimum effective height across the opening’s along-wall span; the spatial manager resolves wall data from the scene and invalidates when height, offset, or support fields change.
Editor UX: Measurement guides, move handles, elevation guides, and wall-top snap highlights sample height at the correct
tinstead of a single constant.Openings: Doors and windows clamp and resize against position-dependent ceiling height (
readHostWallCeiling/readHostWallCeilingMaxWidth); placement and commit requirefitsso openings cannot poke through a sloped top unless Alt force-place.Reviewed by Cursor Bugbot for commit a51d552. Bugbot is set up for automated code reviews on this repo. Configure here.