fix(viewer): stop isolation and solo from overwriting each other's layer masks

[toycenterboss-bot]

What does this PR do?

Isolation (lib/isolation.ts) and solo's shadow-caster-only pass (lib/shadow-only.ts)
both hide an object by clearing its SCENE_LAYER bit, and each stashed the object's
previous layers.mask under its own private Symbol, restoring it wholesale on the
way out.

That holds while the two nest. Interleaved, the second to finish writes back a mask the
first has since changed:

1. Solo a floor. Levels above it go shadow-caster-only; shadow-only stashes the
   original mask.
2. Isolate a wall. isolation stashes the current mask — which is now the
   shadow-only one.
3. Leave solo. shadow-only restores what it stashed, so every level gets its scene
   layer back while the isolation filter is still up. Everything the filter was
   hiding reappears.
4. Clear isolation. isolation restores what it stashed, so the level ends up
   shadow-caster-only with nothing soloed — invisible until reload.

The other order (isolate → solo → clear isolation) breaks the same way, leaving a level
stuck in the shadow pass.

Fix. A small module, lib/scene-visibility.ts, owns Object3D.layers for both
features. Callers name a reason (isolated, shadow-only) rather than handing over a
mask. The snapshot is taken once, when the first reason arrives; the mask is recomputed
from that snapshot while any reason holds; the original is handed back only when the last
reason leaves. Order stops mattering, and the two duplicated stash implementations
collapse into one.

Behaviour is unchanged whenever only one of the two is active.

How to test

Automated — bun run test --filter @pascal-app/viewer:

• src/lib/isolation.test.ts drives the real applyIsolation / applyShadowOnly pair in
  both interleavings. Both cases fail on main and pass here — I verified by
  restoring just isolation.ts and shadow-only.ts from main and re-running: 2 fail,
  1 pass (the third test covers solo being re-applied every frame, which was already
  correct).
• src/lib/scene-visibility.test.ts covers the module itself: reason stacking, unwind
  order, idempotent re-hide, dropping a reason that was never held, and an object that was
  already off the scene layer before anything hid it.

Manually, in a scene with more than one level:

1. Solo a lower level, so the levels above it go shadow-caster-only.
2. Isolate a single wall on the soloed level.
3. Leave solo — on main the hidden levels come back while the filter is still on; here
   they stay hidden.
4. Clear isolation — on main the level stays invisible until reload; here everything
   returns to normal.

Checklist

• Tested locally with bun dev
• bun check clean
• bun check-types clean
• Targets main

---

Note

Medium Risk
Touches core viewer rendering visibility (layer masks) for isolation and solo; behavior is well covered by new tests but incorrect logic would show wrong geometry in the 3D view.

Overview
Fixes a bug where isolation and solo (shadow-only) each stashed and restored Object3D.layers.mask independently, so when both were active the feature that cleared second could restore a stale mask—e.g. hidden levels reappearing while isolation was still on, or a level stuck invisible after clearing isolation.

Introduces scene-visibility.ts as the single owner of scene-layer hiding: callers pass a reason (isolated | shadow-only) via hideFromScene / showInScene. The original mask is snapshotted once; the mask is recomputed while any reason remains; the snapshot is restored only when the last reason is dropped. isolation.ts and shadow-only.ts are wired through this API instead of per-feature Symbols.

Adds scene-visibility.test.ts (stacking, unwind order, idempotency) and isolation.test.ts (interleaved solo/isolation scenarios that failed on main).

^{Reviewed by Cursor Bugbot for commit 8c0d835. Bugbot is set up for automated code reviews on this repo. Configure here.}

[Aymericr]

Reviewed against the viewer layer/visibility contracts and tested on the PR head plus a local merge with current main. The reason-based layer ownership preserves isolation and shadow-only state in either teardown order; focused tests (9) and the viewer dependency typecheck pass. Ready to merge after the maintainer's local visual smoke.

[Aymericr]

Thank you, @toycenterboss-bot. The interleaved solo/isolation reproduction was excellent: it exposed that two features were independently restoring stale layer masks instead of sharing ownership. The reason-based visibility owner is simpler, removes duplicated stash logic, and the tests cover both teardown orders.

I completed the final viewer-boundary and current-main compatibility pass. CI is green, the change is public viewer infrastructure only, and it is the required foundation for the wall-batching work in #608.

Merging this first, as designed. Credit for the contribution remains with Andrei Efremov in the squash commit and PR history.