Skip to content

3.9.0 - #6045

Merged
davimacedo merged 2 commits into
parse-community:masterfrom
back4app:v3.9.0
Sep 12, 2019
Merged

3.9.0#6045
davimacedo merged 2 commits into
parse-community:masterfrom
back4app:v3.9.0

Conversation

@davimacedo

Copy link
Copy Markdown
Member

No description provided.

@davimacedo
davimacedo requested a review from TomWFox September 12, 2019 21:45
@dplewis

dplewis commented Sep 12, 2019

Copy link
Copy Markdown
Member

Can you do a S3Adapter release?

@davimacedo

Copy link
Copy Markdown
Member Author

sure!

@TomWFox TomWFox left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we definitely should develop a standard format for all change logs.

@davimacedo

Copy link
Copy Markdown
Member Author

and also automate it :)

@dplewis

dplewis commented Sep 12, 2019

Copy link
Copy Markdown
Member

We could enforce updating changelog as part of the PR workflow

@davimacedo
davimacedo merged commit 6edaa2e into parse-community:master Sep 12, 2019
@codecov

codecov Bot commented Sep 13, 2019

Copy link
Copy Markdown

Codecov Report

Merging #6045 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6045      +/-   ##
=========================================
- Coverage   93.73%   93.7%   -0.03%     
=========================================
  Files         164     164              
  Lines       11151   11151              
=========================================
- Hits        10452   10449       -3     
- Misses        699     702       +3
Impacted Files Coverage Δ
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.27% <0%> (-0.71%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 97.01% <0%> (-0.09%) ⬇️
src/RestWrite.js 93.72% <0%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eef530b...6a8fa61. Read the comment docs.

7 similar comments
@codecov

codecov Bot commented Sep 13, 2019

Copy link
Copy Markdown

Codecov Report

Merging #6045 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6045      +/-   ##
=========================================
- Coverage   93.73%   93.7%   -0.03%     
=========================================
  Files         164     164              
  Lines       11151   11151              
=========================================
- Hits        10452   10449       -3     
- Misses        699     702       +3
Impacted Files Coverage Δ
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.27% <0%> (-0.71%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 97.01% <0%> (-0.09%) ⬇️
src/RestWrite.js 93.72% <0%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eef530b...6a8fa61. Read the comment docs.

@codecov

codecov Bot commented Sep 13, 2019

Copy link
Copy Markdown

Codecov Report

Merging #6045 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6045      +/-   ##
=========================================
- Coverage   93.73%   93.7%   -0.03%     
=========================================
  Files         164     164              
  Lines       11151   11151              
=========================================
- Hits        10452   10449       -3     
- Misses        699     702       +3
Impacted Files Coverage Δ
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.27% <0%> (-0.71%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 97.01% <0%> (-0.09%) ⬇️
src/RestWrite.js 93.72% <0%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eef530b...6a8fa61. Read the comment docs.

@codecov

codecov Bot commented Sep 13, 2019

Copy link
Copy Markdown

Codecov Report

Merging #6045 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6045      +/-   ##
=========================================
- Coverage   93.73%   93.7%   -0.03%     
=========================================
  Files         164     164              
  Lines       11151   11151              
=========================================
- Hits        10452   10449       -3     
- Misses        699     702       +3
Impacted Files Coverage Δ
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.27% <0%> (-0.71%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 97.01% <0%> (-0.09%) ⬇️
src/RestWrite.js 93.72% <0%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eef530b...6a8fa61. Read the comment docs.

@codecov

codecov Bot commented Sep 13, 2019

Copy link
Copy Markdown

Codecov Report

Merging #6045 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6045      +/-   ##
=========================================
- Coverage   93.73%   93.7%   -0.03%     
=========================================
  Files         164     164              
  Lines       11151   11151              
=========================================
- Hits        10452   10449       -3     
- Misses        699     702       +3
Impacted Files Coverage Δ
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.27% <0%> (-0.71%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 97.01% <0%> (-0.09%) ⬇️
src/RestWrite.js 93.72% <0%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eef530b...6a8fa61. Read the comment docs.

@codecov

codecov Bot commented Sep 13, 2019

Copy link
Copy Markdown

Codecov Report

Merging #6045 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6045      +/-   ##
=========================================
- Coverage   93.73%   93.7%   -0.03%     
=========================================
  Files         164     164              
  Lines       11151   11151              
=========================================
- Hits        10452   10449       -3     
- Misses        699     702       +3
Impacted Files Coverage Δ
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.27% <0%> (-0.71%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 97.01% <0%> (-0.09%) ⬇️
src/RestWrite.js 93.72% <0%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eef530b...6a8fa61. Read the comment docs.

@codecov

codecov Bot commented Sep 13, 2019

Copy link
Copy Markdown

Codecov Report

Merging #6045 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6045      +/-   ##
=========================================
- Coverage   93.73%   93.7%   -0.03%     
=========================================
  Files         164     164              
  Lines       11151   11151              
=========================================
- Hits        10452   10449       -3     
- Misses        699     702       +3
Impacted Files Coverage Δ
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.27% <0%> (-0.71%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 97.01% <0%> (-0.09%) ⬇️
src/RestWrite.js 93.72% <0%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eef530b...6a8fa61. Read the comment docs.

@codecov

codecov Bot commented Sep 13, 2019

Copy link
Copy Markdown

Codecov Report

Merging #6045 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6045      +/-   ##
=========================================
- Coverage   93.73%   93.7%   -0.03%     
=========================================
  Files         164     164              
  Lines       11151   11151              
=========================================
- Hits        10452   10449       -3     
- Misses        699     702       +3
Impacted Files Coverage Δ
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.27% <0%> (-0.71%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 97.01% <0%> (-0.09%) ⬇️
src/RestWrite.js 93.72% <0%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eef530b...6a8fa61. Read the comment docs.

@omairvaiyani

Copy link
Copy Markdown
Contributor

What do you guys currently do when writing changelogs? I use conventional changelogs as part of the release script for our production apps

@TomWFox

TomWFox commented Sep 13, 2019

Copy link
Copy Markdown
Contributor

It's all done manually, which wasn't too bad until recently.

@omairvaiyani

Copy link
Copy Markdown
Contributor

Using conventional commits can definitely make life much easier. We'll not need to enforce commit message structure for our contributors, but we just need to enforce the structure when merging the PRs. The changelog will automatically be generated using the commit message upon release.

@TomWFox

TomWFox commented Sep 13, 2019

Copy link
Copy Markdown
Contributor

Yep, as long as we use squash and merge commits that works perfectly. Thanks for the info!

@TomWFox TomWFox mentioned this pull request Sep 13, 2019
@TomWFox TomWFox added the release label Mar 1, 2020
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
* 3.9.0

* Update s3-files-adapter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants