docs: Clarify LiveQuery options in --help output - #10558
Conversation
|
🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review. Tip
Note Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect. Caution Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughLiveQuery option documentation now explains class-based event publishing, LiveQuery server startup, and the relationship between ChangesLiveQuery documentation
Estimated code review effort: 1 (Trivial) | ~3 minutes Suggested reviewers: Caution Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (1 error, 1 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## alpha #10558 +/- ##
=======================================
Coverage 92.69% 92.69%
=======================================
Files 193 193
Lines 17027 17027
Branches 248 248
=======================================
Hits 15784 15784
Misses 1222 1222
Partials 21 21 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@dblythy Please let CR review first before requesting a human review, thanks. |
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
@coderabbitai can you approve? |
|
✅ Action performedComments resolved and changes approved. |
|
🎉 This change has been released in version 9.10.1-alpha.4 |
Closes #6910
Two of the three LiveQuery options in
--helpboth claim to start the LiveQuery server, which is misleading:The trap (per the issue): you can start the server and get connections/subscriptions, but no create/update/delete events arrive - because events are only published for the classes set in
liveQuery.classNames, which isn't obvious from the help text.This rewords all three (
liveQuery,startLiveQueryServer,liveQueryServerOptions) to spell out thatliveQuery.classNamesis what makes events flow, and that a minimal working setup isliveQuery: { classNames: [...] }plusstartLiveQueryServer. Docs-only - regeneratedDefinitions.jsanddocs.jsfromindex.js.Summary by CodeRabbit
classNamescontrols which create/update/delete events are delivered.