fix(models): support PEP 604 unions in discriminator cache - #38
Open
danielgaskins wants to merge 1 commit into
Open
danielgaskins wants to merge 1 commit into
danielgaskins wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20.
PEP 604 unions cannot be weakly referenced on Python 3.10 through 3.13. When response validation falls back to loose construction, the discriminator cache uses the raw union as a
WeakKeyDictionarykey and raisesTypeError.The cache now uses the equivalent
typing.Unionas its key on affected Python versions. The original PEP 604 type is still used for response parsing.Added coverage for plain PEP 604 unions, discriminated unions, and repeated cache access.
Checked with: