Repository navigation
feat(shortcuts): use game artwork for pinned icons - #259
Merged
Merged
Conversation
Owner
Author
|
Staged in the Nova 1.4.0 integration PR #267 with its original commits preserved. The Game Detail conflict was resolved by retaining both artwork-backed shortcut icons and the newer state-aware pin confirmation flow. This PR will remain open until the integration PR passes and merges. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
iconartwork through the existing memory, disk, and bounded fetch pathic_pc_scutas the fail-closed fallback when trusted game artwork is unavailableThis changes the icon used when a player pins a game. It does not discover missing artwork or change Artwork Studio matching; those remain host/catalog responsibilities.
Refreshed integration verification
Exact head:
f6e580d04bba0f03d2d2b3a69483ef5acc7e3bf3The feature branch was merged forward, without rewriting history, onto protected Nova
masterate8b3d3fcae35af58c1366a74048933095c17b231.Device evidence and remaining gate
Earlier feature-only evidence proved that Launcher3 accepted and pinned Phasmophobia with a persisted bitmap, exact
ShortcutTrampoline, host/game/HDR extras, and a visible home tile; no game or stream was launched, and the test device was restored.That evidence predates the refreshed integration head and is retained as supporting evidence only. A short exact-head pin/remove smoke is still required before this draft is ready.
Boundaries
No poster cropping, artwork discovery, second downloader, shortcut lifecycle expansion, release, tag, or device activation is included.