Improve tracing-test-utils - #250
Merged
Merged
Conversation
Generate changelog in
|
iamdanfox
reviewed
Sep 4, 2019
| @@ -0,0 +1,28 @@ | |||
| {"traceId":"6c07650507d1dc08","parentSpanId":null,"spanId":"c12ba93b80b19725","operation":"task-queue-time1","startTimeMicroSeconds":1567180389235355,"durationNanoSeconds":11956324,"metadata":{}} | |||
Contributor
There was a problem hiding this comment.
I think this file is redundant?
iamdanfox
approved these changes
Sep 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
Didn't serialize/deserialize span type.
Also, there were some bugs that were fixed in #247.
After this PR
==COMMIT_MSG==
tracing-test-utils: Fix ordering bugs in SpanAnalyser, and correctly serde span type.
==COMMIT_MSG==
Possible downsides?