Skip to content

Add persistent volume for repository cache - #210

Merged
softwarefactory-project-zuul[bot] merged 3 commits into
packit:mainfrom
lachmanfrantisek:add-pv-for-repository-cache
Jul 29, 2021
Merged

softwarefactory-project-zuul[bot] merged 3 commits into
packit:mainfrom
lachmanfrantisek:add-pv-for-repository-cache

Conversation

@lachmanfrantisek

Copy link
Copy Markdown
Member

Add persistent volume to the worker for repository-cache.

@softwarefactory-project-zuul

Copy link
Copy Markdown
Contributor

Build succeeded.

@jpopelka jpopelka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@TomasTomecek TomasTomecek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should only keep trying this on stg before we feel confident in bringing it to prod

also, do we have documentation for how to update the cache? (asking b/c ReadWriteOnce is scaring me)

@lachmanfrantisek

lachmanfrantisek commented May 20, 2021 •

Copy link
Copy Markdown
Member Author

I wonder if we should only keep trying this on stg before we feel confident in bringing it to prod

Empty cache on prod should not cause any problems. So we can try first on stage without any change in deployment.

also, do we have documentation for how to update the cache? (asking b/c ReadWriteOnce is scaring me)

  • If you mean the Once in the type, it means The volume can be mounted as read-write by a single node. Yes, you've scared me a bit..;)
  • And regarding the process, we can start with the manual approach as we've discussed.

@softwarefactory-project-zuul

This comment has been minimized.

The only option on OpenShift Online is AWS EBS provisioning
supporting only `ReadWriteOnce` access:
https://docs.openshift.com/online/pro/architecture/additional_concepts/storage.html#pv-restrictions

Because of that, we need to have one repository-cache for each worker.

The volume is mounted to /repository-cache path.

Signed-off-by: Frantisek Lachman <flachman@redhat.com>
Signed-off-by: Frantisek Lachman <flachman@redhat.com>
@softwarefactory-project-zuul

This comment has been minimized.

@softwarefactory-project-zuul

This comment has been minimized.

@softwarefactory-project-zuul

This comment has been minimized.

@softwarefactory-project-zuul

Copy link
Copy Markdown
Contributor

Build failed.

@softwarefactory-project-zuul

Copy link
Copy Markdown
Contributor

Build succeeded.

@lachmanfrantisek
lachmanfrantisek marked this pull request as ready for review July 21, 2021 09:03
@lachmanfrantisek

Copy link
Copy Markdown
Member Author

@jpopelka Can you please take a look? What we need is to define for each worker:

  • one PVC in the prod/stage namespace and mount it
  • one PVC in the sandbox namespace that will be mounted through sandcastle using SANDCASTLE_REPOSITORY_CACHE_VOLUME env var of the worker.

@jpopelka jpopelka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a suggestion

Comment thread playbooks/deploy.yml Outdated
@softwarefactory-project-zuul

Copy link
Copy Markdown
Contributor

Build succeeded.

For each worker, we need to have:
* One volume in the worker's namespace and mount it to the worker.
* One volume in the sandbox namespace and mount it via sandcastle.

Signed-off-by: Frantisek Lachman <flachman@redhat.com>
@lachmanfrantisek

Copy link
Copy Markdown
Member Author

I am dropping the Configure repository-cache volume for sandcastle commit, this needs to be done elsewhere: packit/packit-service#1170

@softwarefactory-project-zuul

Copy link
Copy Markdown
Contributor

Build succeeded.

@lachmanfrantisek lachmanfrantisek added the mergeit Merge via Zuul label Jul 29, 2021
@softwarefactory-project-zuul

Copy link
Copy Markdown
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul
softwarefactory-project-zuul Bot merged commit e583b52 into packit:main Jul 29, 2021
@lachmanfrantisek
lachmanfrantisek deleted the add-pv-for-repository-cache branch July 29, 2021 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mergeit Merge via Zuul

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants