Skip to content

Handle IPv4 options #571

Description

@luqmana

Today we just swallow any IPv4 options we encounter and never emit any ourselves:

// TODO: actually capture and re-emit ipv4 options.
// before, they were accidentally *becoming* the ULP.
// now, we're at least skipping them.
let remaining_bytes = (hdr_len as usize) - Ipv4HdrRaw::SIZE;
rdr.seek(remaining_bytes)
.map_err(|_| Ipv4HdrError::HeaderTruncated { hdr_len })?;

Need to decide if we'll just let them through as-is or on a per-option basis. Will we need to rewrite the contents on ingress/egress?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    featurePlanned and requested features

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions