Repository navigation
Conversation
jmalnuit
requested review from
AlexisAfonso,
ErikssonJoakim,
Tsiorifamonjena,
aTurmo,
achrafHafedh,
aottr,
atefzed,
erazafimovh,
fredericvilcot,
ghyenne,
ielaibouovh,
lolottetheclash,
maelovh,
pauldkn and
stif59100
October 1, 2026 13:10
F1 Turkey - accounts whose address country is TR get a mandatory MERSIS No (16 digits) for company legal forms, the VAT field relabelled "Numéro de KDV" (10 digits) and an "I have a VAT number" checkbox that makes the KDV mandatory. The e-invoicing "Autre" category controls (MANAGER-22014, behind the account:fr-e-invoicing-other-category flag) now also apply to Turkey, and the generic FR validation warning gives way to the category switch warning instead of repeating it. Signed-off-by: jmalnuit <jonathan.malnuit@ovhcloud.com> Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The "Autre" category reminder (OtherCategoryModal) now also applies to Turkish accounts. A new missing-CNIN reminder is queued right after it, for FR/TR accounts carrying the missingCNIN certificate (provisional value, still to be confirmed): at most once an hour, with a CTA to the CNIN field of the account edition; its description names the local identifier (SIRET in France, MERSIS No in Turkey). Signed-off-by: jmalnuit <jonathan.malnuit@ovhcloud.com> Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
For a TR address, the MERSIS No is mandatory (16 digits) for company
legal forms, the VAT label is looked up by country ("KDV", Turkey not
being a subsidiary) and an "I have a VAT number" checkbox makes the
KDV (10 digits) mandatory.
Signed-off-by: jmalnuit <jonathan.malnuit@ovhcloud.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
jmalnuit
force-pushed
the
feat/f1onManagerTurkiye
branch
from
October 1, 2026 13:31
2f225dd to
4674b80
Compare
added 2 commits
October 2, 2026 09:55
The e-invoicing "Autre" controls of the account edition form (error, blocked save, company-data warning) now always apply to FR and TR customers: they are a lasting rule. The account:fr-e-invoicing-other-category flag only gates the temporary home reminder (OtherCategoryModal). Signed-off-by: jmalnuit <jonathan.malnuit@ovhcloud.com>
RG1 asks for the reminder "at every login": once dismissed, it now stays closed for the rest of the browser session instead of coming back on every page load. Turkish accounts get the same request without the French e-invoicing reform wording and its economie.gouv.fr link. Signed-off-by: jmalnuit <jonathan.malnuit@ovhcloud.com>
| * one and `OtherCategoryModal`). The specification writes "TK" | ||
| * for Turkey; the API country code is `TR` (`TK` is Tokelau). | ||
| */ | ||
| export const COMPLIANCE_MODAL_COUNTRIES = ['FR', 'TR']; |
Contributor
There was a problem hiding this comment.
Can we have this on feature flipping side ? We can utilise it same on V8 as well.
| } from './complianceReminderModal.constants'; | ||
|
|
||
| export const isComplianceModalCountry = (country?: string | null) => | ||
| COMPLIANCE_MODAL_COUNTRIES.includes((country ?? '').toUpperCase()); |
Contributor
There was a problem hiding this comment.
Suggestion: TO have a feature flipping check.
| * the MERSIS No in Turkey (the only two countries the reminder is shown in). | ||
| */ | ||
| export const missingCninDescriptionKey = (country?: string | null) => | ||
| (country ?? '').toUpperCase() === 'FR' |
Contributor
There was a problem hiding this comment.
Suggestion: See if you can keep it on feature flipping or atlease if have same contry check for both missingCninDescriptionKey and missingCninFieldToFocus we can keep "FR" on constant file.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
F1 Turkey and e-invoicing compliance, for accounts whose address country is TR
(the API country code; the specification writes "TK", which is Tokelau).
Turkish customers belong to the FR subsidiary.
Account edition form (
@ovh-ux/manager-account)US1 - MERSIS No and KDV
companyNationalIdentificationNumber) shown and mandatory forcorporation, personalcorporation, association and administration, even without an
API rule; 16 digits (the API
regularExpressionwins, the pattern is a fallback).when a KDV is stored. Form state only, never sent to
PUT /menor/newAccount/rules.US2 - "Autre" category (reuses MANAGER-22014)
warning) now also apply to Turkey (
OTHER_CATEGORY_COUNTRIES= FR + DROM + TR).account:fr-e-invoicing-other-categoryflag: they are a lasting rule. The flag now only gates the temporary home reminder.
repeating it.
Container (
@ovh-ux/manager-container-app)US2 - "Autre" category reminder (
OtherCategoryModal, MANAGER-22014)account:fr-e-invoicing-other-category.and its economie.gouv.fr link.
US3 - missing CNIN reminder (
MissingCninModal, new)missingCNINcertificate (provisional value, still to beconfirmed), queued right after
OtherCategoryModal.edition (SIRET search in FR, MERSIS No in TR); the description names the local
identifier.
Account creation (
@ovh-ux/manager-account-creation-app)US1 - same MERSIS No / KDV / checkbox rules on the details step; the VAT label is
looked up by country for Turkey ("KDV"), Turkey not being a subsidiary.
Impact on MANAGER-22014 (FR)
Notes
Messages_fr_FR.jsonis added (translations follow theusual flow).
OtherCategoryModal,MissingCninModal, queue) andaccount-creation (
turkeyHelper). The AngularJS edition form module has no specsuite; it was tested manually.
Related