Repository navigation
Remove notebook_results_path from filesystem; release 0.1.8 - #11
Merged
Merged
Conversation
Per-notebook results folders are a tutorials concern, so the helper now lives in the simkit-tutorials repo's utils.py. save_figure and save_animation stay. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Drops filesystem.notebook_results_path (shipped in 0.1.7) and adds changelog sections for 0.1.7 and 0.1.8. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
simkit shouldn't know about notebooks. This PR removes
simkit.filesystem.notebook_results_path, which shipped in 0.1.7. The helper now lives in the simkit-tutorials repo'sutils.py, and every tutorial notebook callsutils.notebook_results_path.save_figureandsave_animationstay unchanged.simkit/filesystem/notebook_results_path.py, its export, and its two tests.Verification: the full test suite passes locally (624 tests). All 26 simkit-tutorials notebooks execute without errors against this branch.
After merge,
v0.1.8gets tagged onmainto publish the release.🤖 Generated with Claude Code