Repository navigation
Conversation
muzahidul-opti
left a comment
muzahidul-opti
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, where do we check client_initialized event based on vuid enable status.
Contributor
Author
this was already implemented here: This will drop any event if there is no valid identifier but there will be a error log. I have added a new condition to check whether the vuid is not null to avoid the log: 3512a65 |
jaeopt
approved these changes
Oct 31, 2024
jaeopt
left a comment
jaeopt
left a comment
Contributor
There was a problem hiding this comment.
LGTM - with a small fix suggestion
Contributor
There was a problem hiding this comment.
Suggested change
| removeVuid(context) | |
| removeVuid(context) | |
| self.vuid = null |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Issues