🌱 Bump github.com/go-logr/logr from 1.4.3 to 1.4.4 - #2856
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe PR updates Changeslogr dependency update
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rashmigottipati The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
5094a34 to
a4f66f6
Compare
|
New changes are detected. LGTM label has been removed. |
tmshort
added
dependencies
There was a problem hiding this comment.
Pull request overview
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Bumps github.com/go-logr/logr to v1.4.4 in both the root module and the nested hack/ci/custom-linters/analyzers/testdata/ module to resolve CI failures caused by GOPROXY=off and a stale pinned version in analyzer testdata.
Changes:
- Update root
go.modto requiregithub.com/go-logr/logr v1.4.4 - Update nested
testdata/go.modto requiregithub.com/go-logr/logr v1.4.4 - Add corresponding
v1.4.4checksums to both root and nestedgo.sum
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go.mod | Updates root module dependency on github.com/go-logr/logr to v1.4.4. |
| go.sum | Adds v1.4.4 sums for github.com/go-logr/logr in the root module. |
| hack/ci/custom-linters/analyzers/testdata/go.mod | Updates the nested testdata module to github.com/go-logr/logr v1.4.4 to align with CI cache availability. |
| hack/ci/custom-linters/analyzers/testdata/go.sum | Adds v1.4.4 sums for github.com/go-logr/logr in the nested testdata module. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Also updates the nested testdata module so unit tests pass with GOPROXY=off. Replaces dependabot PR #2847 which only updated the root module. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Todd Short <tshort@redhat.com>
a4f66f6 to
7813eb4
Compare
Summary
github.com/go-logr/logrfromv1.4.3tov1.4.4in the root modulehack/ci/custom-linters/analyzers/testdata/(a nested module), fixing theunit-test-basicCI failure in dependabot PR 🌱 Bump github.com/go-logr/logr from 1.4.3 to 1.4.4 #2847Why #2847 was failing
The
TestSetupLogErrorChecktest uses theanalysistestframework to compiletestdata/main.go, which importsgithub.com/go-logr/logr. The testdata has its owngo.modthat was pinned tov1.4.3. CI runs withGOPROXY=off, so when the root module was bumped tov1.4.4the CI module cache no longer hadv1.4.3, causing the import to fail withcould not import github.com/go-logr/logr (invalid package name: "").Closes #2847.
Test plan
unit-test-basicCI passes🤖 Generated with Claude Code
Summary by CodeRabbit