Skip to content

resolve digest-only tags in ResolvePullSpec for PreserveOriginal imports #5172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
May 12, 2026
Merged

resolve digest-only tags in ResolvePullSpec for PreserveOriginal imports #5172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pkg/steps/release/import_release.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,7 @@ oc create configmap release-%s --from-file=%s.yaml=${ARTIFACT_DIR}/%s
for _, tag := range releaseIS.Spec.Tags {
existing.Insert(tag.Name)
tag.ReferencePolicy.Type = referencePolicy
tag.Reference = false
tag.ImportPolicy.ImportMode = imagev1.ImportModePreserveOriginal
tags = append(tags, tag)
}
Expand All @@ -250,6 +251,7 @@ oc create configmap release-%s --from-file=%s.yaml=${ARTIFACT_DIR}/%s
}
existing.Insert(tag.Name)
tag.ReferencePolicy.Type = referencePolicy
tag.Reference = false
tag.ImportPolicy.ImportMode = imagev1.ImportModePreserveOriginal
tags = append(tags, tag)
}
Expand Down
3 changes: 3 additions & 0 deletions pkg/util/imagestream.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,9 @@ func ResolvePullSpec(is *imageapi.ImageStream, tag string, requireExact bool) (s
exists = true
break
}
} else if requireExact && strings.Contains(tags.Items[0].DockerImageReference, "@sha256:") {
pullSpec = tags.Items[0].DockerImageReference
exists = true
Comment thread
deepsm007 marked this conversation as resolved.
}
break
}
Expand Down