Skip to content

Fix localized notifications showing no title or body - #3411

Merged
MartinaeyNL merged 7 commits into
mainfrom
bugfix/localized-notifications-show-no-title-or-body
Oct 16, 2026
Merged

Fix localized notifications showing no title or body#3411
MartinaeyNL merged 7 commits into
mainfrom
bugfix/localized-notifications-show-no-title-or-body

Conversation

@Ekhorn

@Ekhorn Ekhorn commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

Description

Checklist

  • 1. Acceptance criteria of the linked issue(s) are met
  • 2. Tests are written and all tests pass
  • 3. Changes are manually tested by you and the reviewer
  • 4. Documentation is written or updated

@Ekhorn Ekhorn self-assigned this Oct 12, 2026
@Ekhorn Ekhorn changed the title Bugfix/localized notifications show no title or body Fix localized notifications showing no title or body Oct 12, 2026
@Ekhorn
Ekhorn force-pushed the bugfix/localized-notifications-show-no-title-or-body branch from 2fd212b to 86ecc37 Compare October 12, 2026 10:57
@Ekhorn
Ekhorn force-pushed the bugfix/localized-notifications-show-no-title-or-body branch from 86ecc37 to f1a6355 Compare October 12, 2026 10:59
@Ekhorn
Ekhorn marked this pull request as ready for review October 12, 2026 11:13
@Ekhorn
Ekhorn requested a review from a team October 12, 2026 11:14
@Ekhorn Ekhorn added the Bug Error or issue in the system label Oct 14, 2026
@Ekhorn Ekhorn assigned MartinaeyNL and unassigned MartinaeyNL Oct 14, 2026
MartinaeyNL
MartinaeyNL reviewed Oct 15, 2026
View reviewed changes
Comment thread ui/app/manager/src/components/notifications/or-notification-form.ts Outdated
Comment thread ui/app/manager/src/components/notifications/or-notification-form.ts Outdated
Comment thread ui/component/model/src/notification.ts
Comment thread ui/app/manager/test/notifications.test.ts Outdated
Comment thread ui/app/manager/test/notifications.test.ts
Ekhorn added 4 commits October 15, 2026 17:58
@Ekhorn
Switch language through the UI in localized notification tests
ed8c0fa
@Ekhorn
Build the realm notification config once for rules and notifications
4919cc3
@Ekhorn
Apply suggestions
72204e7
@Ekhorn
Share notification language helpers through the model
2a5d2f5 
Move getRealmNotificationConfig, getNotificationLanguages and
resolveNotificationMessage from core into @openremote/model, which the
rules editor and the notifications page both depend on, and use the
model's types in place of the extra aliases. The form keeps its message
type to itself and stops tracking the localized messages as state, as
they are never rendered.
@sonarqubecloud

sonarqubecloud Bot commented Oct 15, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Ekhorn
Ekhorn requested a review from MartinaeyNL October 16, 2026 07:27
MartinaeyNL
MartinaeyNL approved these changes Oct 16, 2026
View reviewed changes

@MartinaeyNL MartinaeyNL left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinaeyNL
MartinaeyNL added this pull request to the merge queue Oct 16, 2026
Merged via the queue into main with commit 3721295 Oct 16, 2026
24 checks passed
@MartinaeyNL
MartinaeyNL deleted the bugfix/localized-notifications-show-no-title-or-body branch October 16, 2026 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MartinaeyNL MartinaeyNL MartinaeyNL approved these changes

Assignees

@Ekhorn Ekhorn

Labels

Bug Error or issue in the system

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Localized notifications show no title or body in the manager UI

2 participants

@Ekhorn @MartinaeyNL