use just one batch of pancreas data - #649
Conversation
|
There are a lot of changes in here... and if I read correctly 3 different "techs", and not 1... no? |
Codecov ReportBase: 94.96% // Head: 94.93% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #649 +/- ##
==========================================
- Coverage 94.96% 94.93% -0.04%
==========================================
Files 152 152
Lines 3876 3867 -9
Branches 203 201 -2
==========================================
- Hits 3681 3671 -10
Misses 128 128
- Partials 67 68 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Ping @LuckyMD I'd like to merge this tomorrow so we can run the benchmark |
LuckyMD
left a comment
There was a problem hiding this comment.
Makes sense to me now... this works, but could be more flexible on keeping different batches.
| @dataset( | ||
| @_pancreas_dataset( | ||
| "Pancreas (alpha=1)", | ||
| dataset_summary=_DATASET_SUMMARY.format(1), |
There was a problem hiding this comment.
where is this summary coming from?
There was a problem hiding this comment.
Defined at the top. Since it's the same (except alpha) for all three, I decided to reuse rather than redefine
Removes batch as a covariate, which might be causing bad performance.
Benchmark passing at https://github.com/scottgigante-immunai/openproblems/actions/runs/3322839154