Repository navigation

Separate model view from view settings for more reliable reload - #99

Merged

pshriwise merged 32 commits into

openmc-dev:developfrom

kkiesling:separate_model_view

Jul 18, 2022

Merged

Separate model view from view settings for more reliable reload#99
pshriwise merged 32 commits into
openmc-dev:developfrom
kkiesling:separate_model_view

Commits on Jul 7, 2022
- rough draft of only restoring view settings, not model settings - this does work
  kkiesling
  committed
  e42ecd9
- remove commented lines and functions that are no longer needed
  kkiesling
  committed
  a253599
- remove unnecessary import
  kkiesling
  committed
  0c6d89f
- remove missed print statement
  
  kkiesling
  and
  paulromano
  committed
  7ce9e4b
- more streamlined to use composition over inheritance
  kkiesling
  committed
  5ee873b
- trying to asses view equality and populating ids
  kkiesling
  committed
  1b187f7
- trying to separate just the view parameters from the rest of view independent - this does not work yet
  kkiesling
  committed
  748baf8
- separate out only the _PlotBase parameters and check those
  kkiesling
  committed
  b130f62
- only store necessary info for reload in pickle file
  kkiesling
  committed
  95ef00e
- cleaned up docstrings
  kkiesling
  committed
  4d371be
- make view params attribute on plotview to simplify
  kkiesling
  committed
  e9e92a0
- remove debugging print statements
  kkiesling
  committed
  3e996c9
- need to copy view params from previous view
  kkiesling
  committed
  eb34f8b
- updated docstrings for new classes
  kkiesling
  committed
  ac39180
Commits on Jul 8, 2022
- Apply suggestions from code review
  
  kkiesling
  and
  paulromano
  authored
  0ff3ed4
- issue warning and ignore plot settings if load fails
  kkiesling
  committed
  ed014f5
- typo
  kkiesling
  committed
  81b41bb
- remove mistaken imports
  kkiesling
  committed
  8051d2f
- ids_map and prop_map don't need to be private
  kkiesling
  committed
  3ab3f4b
Commits on Jul 11, 2022
- wording changes
  
  authored
  7e3ecd3
- need to add view_params to list of attributes
  
  kkiesling
  and
  paulromano
  authored
  ca2eab5
- increment plotmodel version
  kkiesling
  committed
  6ad6cde
- simplify try/except statement
  kkiesling
  committed
  08a9a38
- use_settings_pkl in docstring
  kkiesling
  committed
  635fbf9
- store full currentView so that view_ind and view_params are both saved
  kkiesling
  committed
  9990c72
- list of attribures as class attribute
  kkiesling
  committed
  6a5f909
- restore domain properties if file hashes are unchanged as well
  kkiesling
  committed
  05743d8
- prop_map and properties attributes were redundant
  kkiesling
  committed
  56e12dd
- adopt_plotbase must be in PlotView to be able to set params
  kkiesling
  committed
  90bf435
- make cell_ids, instances, and mat_ids properties
  kkiesling
  committed
  8825405
Commits on Jul 13, 2022
- make initial view the currentview and always create a default view
  kkiesling
  committed
  ebe5460
- compare active and current views before updating current view to check if mapping needs to be called again
  kkiesling
  committed
  9ae7a76

Commits

Commits on Jul 7, 2022

Commits on Jul 8, 2022

Commits on Jul 11, 2022

Commits on Jul 13, 2022