Repository navigation
Avoid warning due to bounding box calculation in Universe.plot - #2681
Merged
Merged
Conversation
Member
|
This will be nice for people who get worried about that warning message. I notice the docstring for Origin includes "Defaults to (0, 0, 0) if the bounding_box contains inf values" but perhaps this should be changed to something like. "inf values in the bounding_box.center get replaced with 0" |
Contributor
Author
|
@shimwell Good suggestion -- I've just updated that. |
shimwell
approved these changes
Sep 13, 2023
shimwell
enabled auto-merge (squash)
September 13, 2023 22:25
stchaker
pushed a commit
to stchaker/openmc
that referenced
this pull request
Oct 25, 2023
apingegno
pushed a commit
to apingegno/openmc
that referenced
this pull request
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some of you may have noticed that running
universe.plot()produces a warning message about an invalid value (for an example, see the screenshot in #2648). This is due to a bounding box calculation where the bounding box has some infinity values in it (that result in ananvalue in thecenterproperty). This PR simply silences the warning since the invalid values are being handled appropriately.Checklist
I have run clang-format on any C++ source files (if applicable)I have made corresponding changes to the documentation (if applicable)