Skip to content

Expose universe plotting for the geometry class - #2661

Merged
pshriwise merged 1 commit into
openmc-dev:developfrom
shimwell:adding_plot_to_geometry
Aug 22, 2023
Merged

pshriwise merged 1 commit into
openmc-dev:developfrom
shimwell:adding_plot_to_geometry

Conversation

@shimwell

@shimwell shimwell commented Aug 21, 2023 •

Copy link
Copy Markdown
Member

As mention in #2648 it would save users accessing the root_universe when plotting a geometry if the plot method was exposed to the openmc.Geometry class.

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@pshriwise pshriwise left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, @shimwell! Pretty straightforward, but I'll give it a 24 hr cooldown for others to take a look as well.

@pshriwise

Copy link
Copy Markdown
Contributor

I went ahead and ticked the testing box for you @shimwell. Given that this relies on the already-tested Universe.plot method I don't think it's necessary to include additional tests here.

@pshriwise
pshriwise merged commit ffbf1b9 into openmc-dev:develop Aug 22, 2023
stchaker pushed a commit to stchaker/openmc that referenced this pull request Oct 25, 2023
apingegno pushed a commit to apingegno/openmc that referenced this pull request May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants