Skip to content

feat: add GetTenantConfig and UpdateTenantConfig RPCs for tenant-specific configuration - #124

Merged
pabloszel11 merged 1 commit into
mainfrom
tenantConfigRPCs
Sep 11, 2026
Merged

feat: add GetTenantConfig and UpdateTenantConfig RPCs for tenant-specific configuration#124
pabloszel11 merged 1 commit into
mainfrom
tenantConfigRPCs

Conversation

@pabloszel11

@pabloszel11 pabloszel11 commented Sep 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Adds tenant-specific configuration support

  • New TenantConfiguration message with optional int32 system_limit
  • GetTenantConfig and UpdateTenantConfig RPCs on the tenant Service
  • UpdateTenantConfigRequest uses google.protobuf.FieldMask for partial updates and field clearing
  • ACTION_UPDATE_TENANT_CONFIG added to the ACTION enum

@pabloszel11
feat: add GetTenantConfig and UpdateTenantConfig RPCs for tenant-spec…
9013cc9 
…ific configuration

Signed-off-by: Pawel Szelag <pablo.szel@gmail.com>
@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: fb771eea-7ac1-43b8-b7de-ebb773b41dfb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 10, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedSep 10, 2026, 1:27 PM

cb80
cb80 reviewed Sep 10, 2026
View reviewed changes
Comment thread proto/kms/api/cmk/registry/tenant/v1/tenant.proto
ACTION_BLOCK_TENANT = 2;
ACTION_UNBLOCK_TENANT = 3;
ACTION_TERMINATE_TENANT = 4;
ACTION_UPDATE_TENANT_CONFIG = 5;

@cb80 cb80 Sep 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this needed for? Where do we use the ACTION enum?

@pabloszel11 pabloszel11 Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's there to be used as a Orbital job type key by Registry

@pabloszel11
pabloszel11 requested a review from cb80 September 11, 2026 08:26
@pabloszel11
pabloszel11 merged commit 57c1d9d into main Sep 11, 2026
10 checks passed
@pabloszel11
pabloszel11 deleted the tenantConfigRPCs branch September 11, 2026 08:45
@push-tags-from-workflow push-tags-from-workflow Bot mentioned this pull request Sep 11, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cb80 cb80 cb80 approved these changes
@alienvspredator alienvspredator alienvspredator approved these changes

Assignees

No one assigned

Labels

api

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pabloszel11 @cb80 @alienvspredator