Skip to content

Proposal: refactor runtime-tools commands #410

Description

@hqhq

We use oci-runtime-tool validate to validate bundle and use make localvalidation for runtime validation, it doesn't look ideal to me, what I thought is:

  • oci-runtime-tool generate for config generation
  • oci-runtime-tool validate bundle for bundle validation
  • oci-runtime-tool validate runtime for runtime validation

As the only tool we offer to user is oci-runtime-tool and runtimetest is only an auxiliary binary for runtime validation, I think runtimetest should not be taken as a first class citizen as oci-runtime-tool is. So I think we should move oci-runtime-tool main code to root directory and put runtimetest codes into some sub directories, put them in cmd directory and generate the two binaries in root directory looks like we are offering two tool binaries.

WDYT about this refactoring, I can help working on this if it looks good to you.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions