Repository navigation
examples: check WebSocket outcomes before continuing - #1281
Conversation
Castiron custom codeEvaluated main: Trusted main policy: ✅ No new custom-code files detected. 0 mixed files remain; 0 existing customizations changed. Compared A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 40429281721 --repo openai/openai-java \
--name castiron-custom-code-40429281721-1 --dir /tmp/castiron-custom-code-40429281721-1
git apply --stat /tmp/castiron-custom-code-40429281721-1/custom-code.patch
cat /tmp/castiron-custom-code-40429281721-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin fafdc0cc51c7bc0e0a087cbcfdf038040f398708 054cda1f13024bfb1a49bf80151b8ede5911c7e3
python3 scripts/castiron/custom_code_report.py report \
--base fafdc0cc51c7bc0e0a087cbcfdf038040f398708 \
--head 054cda1f13024bfb1a49bf80151b8ede5911c7e3 --target-branch main --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-054cda1f1302
cat /tmp/castiron-custom-code-054cda1f1302/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
markstuart-oai
changed the title
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
jbeckwith-oai
left a comment
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Reviewed completed-status gates before Responses continuation and Realtime success, plus the Live startup/send-before-close guard. Existing timeout and resource cleanup remain intact. No actionable findings.
Static review of 250241b with an independent reviewer. Hosted checks show no failures; applicable checks passed and some jobs were skipped. No candidate code or local tests were run.
The Responses example checks each response status before it uses an ID or sends a continuation. The Realtime example checks the status on
response.done. The Live example rejectssession.closedbefore it has sent its three audio frames and close request; after that sequence, all valid session close reasons still confirm finalization.Validation: the Responses and Realtime examples previously compiled against published SDK 4.92.0 and passed 11 local WebSocket cases. The Live example compiled with JDK 21, Java 11 release mode and
-Werroragainst published SDK 4.93.0. Seven real local WebSocket cases cover early closure, all five close reasons after the send sequence, and server errors. The early-closure case fails on the previous code and passes after this change. The SDK's:openai-java-example:formatJavaandlintJavachecks pass.