Skip to content

chore: adopt the existing custom-code budget on next - #1248

Closed
jbeckwith-oai wants to merge 1 commit into
nextfrom
codex/java-next-budget-policy
Closed

jbeckwith-oai wants to merge 1 commit into
nextfrom
codex/java-next-budget-policy

Conversation

@jbeckwith-oai

Copy link
Copy Markdown
Contributor

Summary

Adopt on next the exact custom-code policy already enforced on main: schema version 1 and a ceiling of 3,000 added-plus-deleted custom patch lines. The dormant next branch currently has no policy. This is a policy-only prerequisite for bringing the current SDK baseline into next-major development.

The file is byte-for-byte identical to main at 199cf8169a49dc72bcf7fd869817917383e5ca77. No higher ceiling, counting changes, exclusions, generation metadata, runtime changes, or CI changes are included. Main's trusted checker measured the proposed reporting candidate at 2,516/3,000; next candidates must receive their own fresh checks.

Validation and approval

JSON parses, exact comparison against main passes, and the commit changes only .castiron-ratchet.json. Human approving review is required before merge; agents must not self-approve or bypass the budget gate. This does not authorize package publication.

Unblocks #1247 after this policy is merged normally.

@jbeckwith-oai
jbeckwith-oai requested a review from a team as a code owner October 20, 2026 19:34
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T19:35:32.323079Z 7660ced PR opened
🔒 Security Review ✅ Completed 2026-10-20T19:35:46.687502Z 7660ced PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@markstuart-oai markstuart-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7660ced37598f6e4f0a522542943e8ea4d572136. No actionable source findings. This one-file PR adopts on next the exact schema 1 / 3,000-line policy blob already enforced by main. The complete diff contains only .castiron-ratchet.json; it does not raise the effective main budget or change counting, exclusions, or generation metadata.

Source-only review; candidate tests were not run. All nine observed non-skipped exact-head hosted checks passed, including CI / required; the Maven publishing check was skipped. The requested human policy approval and applicable checks are still required before merge. This automated source review does not substitute for that human approval.

@jbeckwith-oai

Copy link
Copy Markdown
Contributor Author

Closing this budget-only proposal as obsolete after removal of customization budgets. It contains no next_policy baseline pin. Next-major baseline adoption and validation will proceed separately with the simplified compiler workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants