Repository navigation
build: bump jvm in / - #1140
build: bump jvm in /#1140dependabot[bot] wants to merge 1 commit into
Conversation
Castiron custom codeEvaluated main: Trusted main policy: ✅ No new custom-code files detected. 0 mixed files remain; 0 existing customizations changed. Compared A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 40531012209 --repo openai/openai-java \
--name castiron-custom-code-40531012209-1 --dir /tmp/castiron-custom-code-40531012209-1
git apply --stat /tmp/castiron-custom-code-40531012209-1/custom-code.patch
cat /tmp/castiron-custom-code-40531012209-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 014f4a2dbb1f2b13655589fe83ba6ef5af4e18b5 a9c3184fc26afd70b2cea3b11e752aca245aa53b
python3 scripts/castiron/custom_code_report.py report \
--base 014f4a2dbb1f2b13655589fe83ba6ef5af4e18b5 \
--head a9c3184fc26afd70b2cea3b11e752aca245aa53b --target-branch main --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-a9c3184fc26a
cat /tmp/castiron-custom-code-a9c3184fc26a/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1b187c784b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| plugins { | ||
| `kotlin-dsl` | ||
| kotlin("jvm") version "2.2.21" | ||
| kotlin("jvm") version "2.4.20" |
There was a problem hiding this comment.
Upgrade the other Kotlin Gradle plugin declaration
Updating only the plugin-DSL version leaves implementation("org.jetbrains.kotlin:kotlin-gradle-plugin:2.2.21") in the buildSrc runtime classpath. The repository's security model identifies that plugin version as affected and explicitly requires upgrading both buildSrc Kotlin plugin declarations to a stable 2.4.20-or-later release (docs/architecture/security-model.md:119-126), so this change does not complete the intended remediation.
AGENTS.md reference: AGENTS.md:L34-L36
Useful? React with 👍 / 👎.
| plugins { | ||
| `kotlin-dsl` | ||
| kotlin("jvm") version "2.2.21" | ||
| kotlin("jvm") version "2.4.20" |
There was a problem hiding this comment.
Preserve the configured Kotlin 1.8 language level
With Kotlin 2.4.20, every SDK module applying openai.kotlin will fail to compile because that convention sets languageVersion to KOTLIN_1_8 (buildSrc/src/main/kotlin/openai.kotlin.gradle.kts:35), and Kotlin 2.3+ rejects -language-version=1.8 as an error. Either retain a Kotlin Gradle plugin that supports the repository's current language contract or migrate that contract in a coordinated compatibility change. Kotlin compatibility guide
AGENTS.md reference: AGENTS.md:L34-L36
Useful? React with 👍 / 👎.
1b187c7 to
f82f4ea
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
f82f4ea to
a76728b
Compare
Bumps [jvm](https://github.com/JetBrains/kotlin) in `/` from 2.2.21 to 2.4.21. Updates `jvm` from 2.2.21 to 2.4.21 - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md) - [Commits](JetBrains/kotlin@v2.2.21...v2.4.21) --- updated-dependencies: - dependency-name: jvm dependency-version: 2.4.20 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: sdk-dependencies/jvm ... Signed-off-by: dependabot[bot] <support@github.com>
a76728b to
a9c3184
Compare
Bumps jvm in
/from 2.2.21 to 2.4.21.Updates
jvmfrom 2.2.21 to 2.4.21Release notes
Sourced from jvm's releases.
... (truncated)
Changelog
Sourced from jvm's changelog.
... (truncated)
Commits
9180ce6Add changelog for 2.4.21-RC851077b[Serialization] Copy type parameter bounds onto generated serializers (#8421)1b6b624[Wasm]: Generate a Kotlin-level cast for bridged lambda functions. (#8404)3c223c2Rrr/2.4.20/core docs (#8322)c681c2e[2.4.20] [KT-89285] Stop the xcodebuild logs being output by default (#8277)f0645d1[2.4.20] [JS] ReorderCompilerConfigurationproperties initialization (#8282)f507ecd[JS] Don't try to initialize an external class's companion objectc60d7d8Reflection: fix NoSuchElementException in ConvertFromJava.kt05d1cdeREPL: render correct reflected binding type5acec47Scripting: store collected dependencies recursively