Allow plugin installs for backend dependency IDs#31694
Draft
cravuri-oai wants to merge 1 commit into
Draft
Conversation
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
request_plugin_installto resolve exact backend plugin IDs when they are not present in<recommended_plugins>orlist_available_plugins_to_install.request_plugin_installavailable in endpoint-recommendation mode even when there are zero static recommendation candidates.Motivation
Plugin Management dependency discovery can return canonical backend plugin IDs for related plugins that are valid and installable but are not part of the small per-turn recommendation list. Today
request_plugin_installrejects those IDs before the user can see the normal install elicitation.This change keeps the existing recommendation/list path unchanged and adds a narrow fallback: resolve the exact backend ID through the existing
/ps/plugins/{plugin_id}detail API, then reuse the existing client-compatible Codex config ID such asslack@openai-curated-remote.Behavior
AVAILABLE, and not already be installed.canonical_plugin_idvalues fromget_plugin_dependenciesonly whencanonical_plugin_status="enabled",canonical_plugin_installation_policy="available", andcanonical_plugin_installed=false.remote_plugin_idand app connector IDs, so Codex desktop and ChatGPT Work mode can reuse their existing install UI.Scope
list_available_plugins_to_install.Validation
just test -p codex-core request_plugin_install— 21 passed.just test -p codex-tools request_plugin_install— 6 passed.just test -p codex-core endpoint_mode_resolves_backend_plugin_id_for_install_elicitation— passed with zero recommendation candidates.just test -p codex-core endpoint_mode_injects_candidates_hides_list_and_rejects_missing_backend_ids— passed.just fix -p codex-core.just fmt.git diff --check.