Skip to content

fix(console): clear stale k8s status text on a successful reload (studio#119) #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brettchien merged 1 commit into from
Aug 28, 2026
Merged

fix(console): clear stale k8s status text on a successful reload (studio#119) #124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions console/src/deploy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,10 @@ export function initDeployPanel(deps: DeployPanelDeps): DeployPanelHandle | null
k8sNamespaceOptions.innerHTML = res.namespaces
.map((n) => `<option value="${escapeHtml(n)}"></option>`)
.join("");
// studio#119: a prior failed attempt (e.g. before switching context)
// can leave its error text on screen — clear it once a load actually
// succeeds, otherwise a stale error outlives the state it described.
setStatus(identityStatusEl, "");
} catch (e) {
// Non-fatal: the namespace field is a free-text input either way (list_
// namespaces failing just means no autocomplete suggestions).
Expand Down Expand Up @@ -238,6 +242,11 @@ export function initDeployPanel(deps: DeployPanelDeps): DeployPanelHandle | null
opts.push(`<option value="${escapeHtml(c.name)}">${escapeHtml(label)}</option>`);
}
k8sContextSel.innerHTML = opts.join("");
// studio#119: same staleness fix as loadK8sNamespaces — the
// loadK8sNamespaces() call below will overwrite this with its own
// result once it resolves, but clear here too so a stale error doesn't
// linger for the gap between the two if that call is slow.
setStatus(identityStatusEl, "");
} catch (e) {
setStatus(identityStatusEl, `k8s context list unavailable: ${errText(e)}`, "err");
}
Expand Down
Loading