build: bump nmilat to v0.2.7, fixing a relay-side PoW mismatch drop - #33
Merged
Conversation
Upstream fix in ohstr/nmilat#10: relay ingestion unconditionally rejected any event whose nonce tag overclaimed its NIP-13 difficulty, regardless of strictPow/--strict-pow (that flag only ever governed ncli's own read-side check, never the destination relay's). Also picks up the go1.26.8 bump nmilat v0.2.6 already required.
…now also catches self-contradictory nonce tags Directly informed by the nmilat v0.2.7 bump: previously any nmilat relay rejected a self-contradictory nonce tag unconditionally, so this distinction didn't matter in practice. Now that it's gated behind Limitation.StrictPow, the relay-side pow.strict doc needed to say what it actually covers, and apply's strictPow doc needed the caveat that it never reached the destination relay's own decision anyway -- the actual root cause of the original bug report.
naliyi
marked this pull request as ready for review
September 4, 2026 08:20
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github.com/ohstr/nmilatv0.2.5 → v0.2.7.noncetag overclaimed its NIP-13 difficulty, on ingest, regardless ofstrictPow/--strict-pow— that ncli setting only ever governed ncli's own read-side verification of events pulled from afromflow, never how the destination relay validated events on write. Fixed upstream in ohstr/nmilat#10, with regression tests that fail on the pre-fix code with the exact reported error and pass on the fix.go.mod'sgodirective updated bygo mod tidy).Test plan
GOWORK=off go build ./...GOWORK=off go vet ./...GOWORK=off go test -short -race ./...(matches CI, all packages green)GOWORK=off go test ./client/... -run Pow -v— existingstrictPowwiring tests unaffected